Aerobridge Guardian (trusted flight module) : JWT verification for flights / vehicle arming #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botmayank
reviewed
Feb 3, 2022
| @@ -15,6 +15,33 @@ void AP_Arming_Copter::update(void) | |||
| display_fail = true; | |||
| pre_arm_display_counter = 0; | |||
| } | |||
| //a sample verification token | |||
| std::string rsa_pub_key = R"(-----BEGIN PUBLIC KEY----- | |||
There was a problem hiding this comment.
Should not have even test tokens in committed changes. Should move this out to an env file how Kapil did for QGC
| auto decoded = jwt::decode(token); | ||
|
|
||
| verify.verify(decoded); | ||
|
|
There was a problem hiding this comment.
Does verify failure block arming? Doesn't look like it. This just seems like a call to verify and an unused retval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial PR for verifying the JWT signature received at the firmware from the ground control station (GCS). Post successful verification, drone arming can be performed.
Work done:
AP_Arming.cppfor verification using the library's APIs.Future Work:
Let me know if you have any suggestions.
Thanks.